[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <200611302130.23556.MalteSch@gmx.de>
Date: Thu, 30 Nov 2006 21:30:19 +0100
From: Malte Schröder <MalteSch@....de>
To: David Miller <davem@...emloft.net>
Cc: kernel@...uxace.com, linux-kernel@...r.kernel.org,
linux-netdev@...r.kernel.org
Subject: Re: Linux 2.6.19
On Thursday 30 November 2006 03:15, David Miller wrote:
> From: Phil Oester <kernel@...uxace.com>
> Date: Wed, 29 Nov 2006 17:49:04 -0800
>
> > Getting an oops on boot here, caused by commit
> > e81c73596704793e73e6dbb478f41686f15a4b34 titled
> > "[NET]: Fix MAX_HEADER setting".
> >
> > Reverting that patch fixes things up for me. Dave?
>
> I suspect that it might be because I removed the IPV6
> ifdef from the list, but I can't imagine why that would
> matter other than due to a bug in the IPV6 stack....
>
> Indeed.
>
> Looking at ndisc_send_rs() I wonder if it miscalculates
> 'len' or similar and the old MAX_HEADER setting was
> merely papering around this bug....
>
> In fact it does, the NDISC code is using MAX_HEADER incorrectly. It
> needs to explicitly allocate space for the struct ipv6hdr in 'len'.
> Luckily the TCP ipv6 code was doing it right.
>
> What a horrible bug, this patch should fix it. Let me know
> if it doesn't, thanks:
I also encountered this bug (wasn't there in -rc6). The patch also fixes it
for me.
regards
--
---------------------------------------
Malte Schröder
MalteSch@....de
ICQ# 68121508
---------------------------------------
Content of type "application/pgp-signature" skipped
Powered by blists - more mailing lists