linux-kernel - Re: [PATCH 2.6.19] kobject: kobject_uevent() returns manageable value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3f250c710612010746y717fa46fof4d887c02a1b345d@mail.gmail.com>
Date:	Fri, 1 Dec 2006 11:46:45 -0400
From:	"Mauricio Lin" <mauriciolin@...il.com>
To:	"Andrew Morton" <akpm@...l.org>
Cc:	"Mauricio Lin" <mauricio.lin@...t.org.br>,
	linux-kernel@...r.kernel.org, greg@...ah.com,
	Ilias.biris@...t.org.br
Subject: Re: [PATCH 2.6.19] kobject: kobject_uevent() returns manageable value

Hi Andrew,

On 12/1/06, Andrew Morton <akpm@...l.org> wrote:
> On Thu, 30 Nov 2006 16:58:47 -0400
> Mauricio Lin <mauricio.lin@...t.org.br> wrote:
>
> > Since kobject_uevent() function does not return an integer value to
> > indicate if its operation was completed with success or not, it is
> > worth changing it in order to report a proper status (success or
> > error) instead of returning void.
> >
> > Keep kobject_uevent() returning the status as integer provide a easier
> > way for detecting possible failure in the function. Using void
> > returning style may take people to waste more time to figure out if
> > the "send to" or "receive from" an event is a bug in the kernel or
> > user space. Furthermore, the current way to detect where the error is
> > taking place in the kobject_uevent() requires additional inclusion of
> > printk() in each "if" condition that can lead to failure.
>
> Admirable idea, but we have large changes pending against that code
> and none of this patch applies.

I have used the kobject_uevent() to send event to user space, but when
the event does not happen I have to figure out if this problem is
related to kernel or user space code. After mentioning this issue with
Greg KH, he recommended to provide a patch to fix it.

>
> A patch against Greg's driver tree, or against latest -mm would suit, thanks.

OK. That's good. Thanks.

BR,

Mauricio Lin.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/