linux-kernel - Re: [GFS2] Change argument of gfs2_dinode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20061201192555.GD3078@ftp.linux.org.uk>
Date:	Fri, 1 Dec 2006 19:25:55 +0000
From:	Al Viro <viro@....linux.org.uk>
To:	Russell Cattelan <cattelan@...barn.com>
Cc:	Steven Whitehouse <swhiteho@...hat.com>, cluster-devel@...hat.com,
	linux-kernel@...r.kernel.org
Subject: Re: [GFS2] Change argument of gfs2_dinode_out [17/70]

On Fri, Dec 01, 2006 at 01:19:04PM -0600, Russell Cattelan wrote:
> On Thu, 2006-11-30 at 12:15 +0000, Steven Whitehouse wrote:
> > >From 539e5d6b7ae8612c0393fe940d2da5b591318d3d Mon Sep 17 00:00:00 2001
> > From: Steven Whitehouse <swhiteho@...hat.com>
> > Date: Tue, 31 Oct 2006 15:07:05 -0500
> > Subject: [PATCH] [GFS2] Change argument of gfs2_dinode_out
> > 
> > Everywhere this was called, a struct gfs2_inode was available,
> > but despite that, it was always called with a struct gfs2_dinode
> > as an argument. By making this change it paves the way to start
> > eliminating fields duplicated between the kernel's struct inode
> > and the struct gfs2_dinode.
> More pointless code churn.
> 
> This only makes sense once the file system is working 
> and we have time to do this type of cleanup on against
> a stable and TESTED code base.

Bzzert.  Cleaner code is easier to _get_ stable.  "Keep it ucking fugly
until everyone stops looking at it out of sheer disgust" is a bad idea.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/