[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20061201193428.GA4055@flint.arm.linux.org.uk>
Date: Fri, 1 Dec 2006 19:34:28 +0000
From: Russell King <rmk+lkml@....linux.org.uk>
To: Scott Wood <scottwood@...escale.com>
Cc: trivial@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Make platform_device_add_data accept a const pointer.
On Fri, Dec 01, 2006 at 12:54:47PM -0600, Scott Wood wrote:
> platform_device_add_data() makes a copy of the data that is given to it,
> and thus the parameter can be const. This removes a warning when data
> from get_property() on powerpc is handed to platform_device_add_data(),
> as get_property() returns a const pointer.
Doesn't this cause a compile warning in platform.c, concerning assigning
'data' to struct device's non-const 'platform_data' pointer?
So in essence you're probably just moving the problem rather than really
solving anything.
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of:
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists