linux-kernel - Re: [RFC] timers, pointers to functions and type safety

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 2 Dec 2006 09:02:52 -0700
From:	Matthew Wilcox <matthew@....cx>
To:	Thomas Gleixner <tglx@...utronix.de>
Cc:	Al Viro <viro@....linux.org.uk>,
	Linus Torvalds <torvalds@...l.org>, linux-arch@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [RFC] timers, pointers to functions and type safety

On Sat, Dec 02, 2006 at 03:45:12PM +0100, Thomas Gleixner wrote:
> What's the cruft ? 
> 
> struct bla = container_of(timer, struct bla, timer); ???

That's it, right there.  Any idea how much we've bloated the kernel with
sysfs, just by insisting that the struct device not be the first item in
the struct?  There's any number of 2- and 3- line functions calling each
other, each adding and subtracting constants from the pointers passed to
them.  This was a huge mistake, IMO.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/