linux-kernel - [PATCH] pci quirks: remove redundant check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64N.0612031153370.18549@attu4.cs.washington.edu>
Date:	Sun, 3 Dec 2006 11:55:34 -0800 (PST)
From:	David Rientjes <rientjes@...washington.edu>
To:	Martin Mares <mj@....cz>, Greg Kroah-Hartman <gregkh@...e.de>
cc:	linux-kernel@...r.kernel.org
Subject: [PATCH] pci quirks: remove redundant check

Removes redundant check for dev->subordinate; if it is NULL, the function 
returns before the patch-affected code region.

Cc: Martin Mares <mj@....cz>
Cc: Greg Kroah-Hartman <gregkh@...e.de>
Signed-off-by: David Rientjes <rientjes@...washington.edu>
---
 drivers/pci/quirks.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
index 9ca9b9b..7571863 100644
--- a/drivers/pci/quirks.c
+++ b/drivers/pci/quirks.c
@@ -1688,8 +1688,7 @@ static void __devinit quirk_nvidia_ck804
 	 * a single one having MSI is enough to be sure that MSI are supported.
 	 */
 	pdev = pci_get_slot(dev->bus, 0);
-	if (dev->subordinate && !msi_ht_cap_enabled(dev)
-	    && !msi_ht_cap_enabled(pdev)) {
+	if (!msi_ht_cap_enabled(dev) && !msi_ht_cap_enabled(pdev)) {
 		printk(KERN_WARNING "PCI: MSI quirk detected. "
 		       "MSI disabled on chipset %s.\n",
 		       pci_name(dev));
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/