linux-kernel - Re: [2.6 patch] FW_LOADER should select HOTPLUG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20061203005824.37bd8e0f.akpm@osdl.org>
Date:	Sun, 3 Dec 2006 00:58:24 -0800
From:	Andrew Morton <akpm@...l.org>
To:	Adrian Bunk <bunk@...sta.de>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [2.6 patch] FW_LOADER should select HOTPLUG

On Sun, 3 Dec 2006 08:16:37 +0100
Adrian Bunk <bunk@...sta.de> wrote:

> Since FW_LOADER is an option that is always select'ed by the code using 
> it, it mustn't depend on HOTPLUG.
> 
> It's only relevant in the EMBEDDED=y case, but this might have resulted 
> in illegal FW_LOADER=, HOTPLUG=n configurations.
> 
> Signed-off-by: Adrian Bunk <bunk@...sta.de>
> 
> --- linux-2.6.19-rc6-mm2/drivers/base/Kconfig.old	2006-12-02 20:36:49.000000000 +0100
> +++ linux-2.6.19-rc6-mm2/drivers/base/Kconfig	2006-12-02 20:37:03.000000000 +0100
> @@ -19,8 +19,8 @@
>  	  If unsure say Y here.
>  
>  config FW_LOADER
> -	tristate "Userspace firmware loading support"
> -	depends on HOTPLUG
> +	tristate
> +	select HOTPLUG

It would be a retrograde step to start selecting HOTPLUG - we've managed to
avoid it thus far.

It'd be better to make those drivers which select FW_LOADER dependent upon
HOTPLUG.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/