linux-kernel - Re: [PATCH] 2.6.18-rt7: fix more issues with 32-bit cycles_t in latency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20061204162300.GA23800@elte.hu>
Date:	Mon, 4 Dec 2006 17:23:00 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Sergei Shtylyov <sshtylyov@...mvista.com>
Cc:	linuxppc-dev@...abs.org, linux-kernel@...r.kernel.org,
	dwalker@...sta.com
Subject: Re: [PATCH] 2.6.18-rt7: fix more issues with 32-bit cycles_t in	latency_trace.c (take 3)



* Sergei Shtylyov <sshtylyov@...mvista.com> wrote:

> > 	/* check for buggy clocks, handling wrap for 32-bit clocks */
> >-	if (TYPE_EQUAL(cycles_t, unsigned long)) {
> >+	if (TYPE_EQUAL(cycle_t, unsigned long)) {
> > 		if (time_after((unsigned long)T1, (unsigned long)T2))
> > 			printk("bug: %08lx < %08lx!\n",
> > 				(unsigned long)T2, (unsigned long)T1);
> 
>    This earlier fix by Kevin woulnd't have sense anymore with cycle_t...

yeah, indeed - i've zapped this one too.

basically, what i'd like is the 32-bit clocks/cycles be handled 
intelligently, and not adding to the cruft that already is in 
kernel/latency_tracing.c.

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/