linux-kernel - Re: [PATCH] Allow 32-bit and 64-bit hashes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0612040832580.3476@woody.osdl.org>
Date:	Mon, 4 Dec 2006 08:36:15 -0800 (PST)
From:	Linus Torvalds <torvalds@...l.org>
To:	Matthew Wilcox <matthew@....cx>
cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Allow 32-bit and 64-bit hashes

On Mon, 4 Dec 2006, Matthew Wilcox wrote:
> 
> You're right.  It hasn't actually caused any problems, presumably due to
> linux/types.h being included absolutely everywhere already, but it's
> clearly the Right Thing To Do.  Updated patch:

I'm still not happy.

The return value of "hash_u64()" had better be  u64, not "unsigned long".

Same goes (to a smaller degree) for hash_u32().

I can trivially just edit the patch and fix these things, but with two 
bugs found by just inspection of the patch, I'm going to ask you to look 
it over one more time and re-send me a "guaranteed correct" version, ok? 

Because I'm a very religious man, and my religion basically boils down to 

  "If somebody else can do it for me, they should. I'm lazy, and I like it 
   that way. Besides, next time maybe they'll double-check on their own".

Thanks. And please spread the Good Word.

		Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/