linux-kernel - Re: [patch] remove redundant iov segment check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <45747BF6.9090502@oracle.com>
Date:	Mon, 04 Dec 2006 11:50:14 -0800
From:	Zach Brown <zach.brown@...cle.com>
To:	"Chen, Kenneth W" <kenneth.w.chen@...el.com>
CC:	Andrew Morton <akpm@...l.org>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	Christoph Hellwig <hch@...radead.org>
Subject: Re: [patch] remove redundant iov segment check


> Maybe we should create another internal generic_file_aio_read/write
> for in-core function? fs/read_write.c and fs/aio.c are not module-able
> and the check is already there.  For external module, we can do the
> check and then calls down to the internal one.

Maybe.  I'd rather see fewer moving parts here, not more.

> I hate to see iov is being walked multiple times ....

Indeed, hence the desire to walk it once and pass down a summary of the
results in an explicit struct.  The patch in this thread removes one
redundancy, but there are many.  I think I counted 6 iovec walks in some
path?  I can't remember which.  I'd rather tackle them all in one go.

- z
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/