linux-kernel - Re: [patch] kill pointless ki_nbytes assignment in aio_setup_single

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <45748388.9030400@oracle.com>
Date:	Mon, 04 Dec 2006 12:22:32 -0800
From:	Zach Brown <zach.brown@...cle.com>
To:	"Chen, Kenneth W" <kenneth.w.chen@...el.com>
CC:	Andrew Morton <akpm@...l.org>,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [patch] kill pointless ki_nbytes assignment in aio_setup_single_vector

Chen, Kenneth W wrote:
> io_submit_one assigns ki_left = ki_nbytes = iocb->aio_nbytes, then
> calls down to aio_setup_iocb, then to aio_setup_single_vector. In there,
> ki_nbytes is reassigned to the same value it got two call stack above it.
> There is no need to do so.
> 
> Signed-off-by: Ken Chen <kenneth.w.chen@...el.com>

That seems to be the case, indeed.

Acked-by: Zach Brown <zach.brown@...cle.com>

- z
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/