linux-kernel - Re: [RFC][PATCH 2/2] x86_64: earlyprintk usb debug device support.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20061204203308.GA30307@suse.de>
Date:	Mon, 4 Dec 2006 12:33:08 -0800
From:	Greg KH <gregkh@...e.de>
To:	"Lu, Yinghai" <yinghai.lu@....com>
Cc:	ebiederm@...ssion.com,
	USB development list <linux-usb-devel@...ts.sourceforge.net>,
	Stefan Reinauer <stepan@...esystems.de>,
	Peter Stuge <stuge-linuxbios@....org>, linuxbios@...uxbios.org,
	linux-kernel@...r.kernel.org, Andi Kleen <ak@...e.de>
Subject: Re: [RFC][PATCH 2/2] x86_64: earlyprintk usb debug device support.

On Mon, Dec 04, 2006 at 12:18:30PM -0800, Lu, Yinghai wrote:
> -----Original Message-----
> From: ebiederm@...ssion.com [mailto:ebiederm@...ssion.com] 
> 
> >arch/x86_64/kernel/early_printk.c |  574
> +++++++++++++++++++++++++++++++++++++
> > drivers/usb/host/ehci.h           |    8 +
> > include/asm-x86_64/fixmap.h       |    1 
> 
> Can you separate usbdebug handle out from early_printk? 

Yeah, at least tear it out of x86-64, so those of us stuck on different
platforms can use this :)

Other than that minor issue, this looks great.  I don't have a x86-64
box set up here at the moment, so I can't test it, but it looks
acceptable at first glance.

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/