linux-kernel - Re: [GFS2] Fix crc32 calculation in recovery.c [8/70]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1165227192.3752.618.camel@quoit.chygwyn.com>
Date:	Mon, 04 Dec 2006 10:13:12 +0000
From:	Steven Whitehouse <swhiteho@...hat.com>
To:	Jan Engelhardt <jengelh@...ux01.gwdg.de>
Cc:	cluster-devel@...hat.com, linux-kernel@...r.kernel.org
Subject: Re: [GFS2] Fix crc32 calculation in recovery.c [8/70]

Hi,

On Sat, 2006-12-02 at 09:40 +0100, Jan Engelhardt wrote:
> >Commit "[GFS2] split and annotate gfs2_log_head" resulted in an incorrect
> >checksum calculation for log headers. This patch corrects the
> >problem without resorting to copying the whole log header as
> >the previous code used to.
> >
> >Cc: Al Viro <viro@...iv.linux.org.uk>
> >Signed-off-by: Steven Whitehouse <swhiteho@...hat.com>
> >---
> > fs/gfs2/recovery.c |    9 +++++----
> > 1 files changed, 5 insertions(+), 4 deletions(-)
> >
> >diff --git a/fs/gfs2/recovery.c b/fs/gfs2/recovery.c
> >index 4478162..4acf238 100644
> >--- a/fs/gfs2/recovery.c
> >+++ b/fs/gfs2/recovery.c
> >@@ -136,6 +136,7 @@ static int get_log_header(struct gfs2_jd
> > {
> > 	struct buffer_head *bh;
> > 	struct gfs2_log_header_host lh;
> >+static const u32 nothing = 0;
> > 	u32 hash;
> > 	int error;
> > 
> 
> At least indent it.
> 

I've had a private email from someone pointing out the same thing. It
was not intended to emphasise the fact that it is static, I'm not sure
if thats the "right thing" or not, but either way, it doesn't actually
need to be static, so that I've agreed that I'll remove the static and
just leave it as const and fix the indenting at the same time,

Steve.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/