linux-kernel - Re: [RFC][PATCH 2/2] x86_64: earlyprintk usb debug device support.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 4 Dec 2006 16:45:21 -0800
From:	Greg KH <gregkh@...e.de>
To:	"Eric W. Biederman" <ebiederm@...ssion.com>
Cc:	"Lu, Yinghai" <yinghai.lu@....com>,
	USB development list <linux-usb-devel@...ts.sourceforge.net>,
	Stefan Reinauer <stepan@...esystems.de>,
	Peter Stuge <stuge-linuxbios@....org>, linuxbios@...uxbios.org,
	linux-kernel@...r.kernel.org, Andi Kleen <ak@...e.de>
Subject: Re: [RFC][PATCH 2/2] x86_64: earlyprintk usb debug device support.

On Mon, Dec 04, 2006 at 02:26:52PM -0700, Eric W. Biederman wrote:
> Greg KH <gregkh@...e.de> writes:
> 
> > On Mon, Dec 04, 2006 at 12:18:30PM -0800, Lu, Yinghai wrote:
> >> -----Original Message-----
> >> From: ebiederm@...ssion.com [mailto:ebiederm@...ssion.com] 
> >> 
> >> >arch/x86_64/kernel/early_printk.c |  574
> >> +++++++++++++++++++++++++++++++++++++
> >> > drivers/usb/host/ehci.h           |    8 +
> >> > include/asm-x86_64/fixmap.h       |    1 
> >> 
> >> Can you separate usbdebug handle out from early_printk? 
> >
> > Yeah, at least tear it out of x86-64, so those of us stuck on different
> > platforms can use this :)
> >
> > Other than that minor issue, this looks great.  I don't have a x86-64
> > box set up here at the moment, so I can't test it, but it looks
> > acceptable at first glance.
> 
> Makes sense.  I'm curious now what architecture do you have?

i386

My main development box these days is a mac mini due to it's great form
factor and ability to suspend to ram easily.  Unfortunately they don't
come with a working 64bit processor just yet.

> Anyway next time I touch this the project will be how to integrate
> this into the kernel cleanly.  This round was to figure out how
> to get some working code.
> 
> If someone beats me to the punch on generalizing this code I won't
> mind.
> 
> The first pass was a success.  And the performance is reasonable
> assuming you don't plug the end you are watching into a usb1 only
> port.
> 
> Given that I didn't really know anything about usb a week ago I think
> I did pretty well :)

Yes, you certainly did, no complaint from me at all about that :)

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/