[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20061205122057.c2b617f4.akpm@osdl.org>
Date: Tue, 5 Dec 2006 12:20:57 -0800
From: Andrew Morton <akpm@...l.org>
To: James Simmons <jsimmons@...radead.org>
Cc: linux-kernel@...r.kernel.org, Yu Luming <luming.yu@...il.com>,
Miguel Ojeda Sandonis <maxextreme@...il.com>
Subject: Re: -mm merge plans for 2.6.20
On Tue, 5 Dec 2006 19:59:01 +0000 (GMT)
James Simmons <jsimmons@...radead.org> wrote:
>
> > > > > > video-sysfs-support-take-2-add-dev-argument-for-backlight_device_register.patch
> > > > >
> > > > > Does this patch update the fbdev drivers?
> > > >
> > > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.19-rc6/2.6.19-rc6-mm2/broken-out/video-sysfs-support-take-2-add-dev-argument-for-backlight_device_register.patch
> > > >
> > > > Seems not. Should it?
> > >
> > > Yes. Its bizarre.
> >
> > It is.
> >
> > > The drivers compile with the wrong method prototype.
> >
> > No, it doesn't get compiled at all.
> >
> > CONFIG_FB_ATY128_BACKLIGHT has no Kconfig record at all.
> >
> > CONFIG_FB_NVIDIA_BACKLIGHT has no Kconfig record at all.
> >
> > CONFIG_FB_RIVA_BACKLIGHT has no Kconfig record at all.
> >
> > So this is all dead code. There is no way to enable any of it within the
> > config system.
>
> Ug. Kconfig in drivers/video has all the above drivers enable the
> backlight only if PMAC_BACKLIGHT is set.
erp, I grepped for CONFIG_foo and not foo. Again.
> The problem is backlight
> is after the framebuffer. We should move the backlight menu before
> the framebuffer configuration.
OK. Can you do a patch sometime please?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists