linux-kernel - [PATCH 2.6.19 1/1] atkb: supress repeated warning messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <17781.55454.538734.421950@wylie.me.uk>
Date:	Tue, 5 Dec 2006 20:37:50 +0000
From:	"Alan J. Wylie" <alan@...ie.me.uk>
To:	linux-kernel@...r.kernel.org
Subject: [PATCH 2.6.19 1/1] atkb: supress repeated warning messages

On Sat, 2 Dec 2006 13:56:13 +0000, "Alan J. Wylie" <alan@...ie.me.uk> said:

> I was presented with a continous stream of error messages:

> atkbd.c: Spurious ACK on isa0060/serio Some program might be trying
> to access hardware directly.

> These seem to be as a result of the keyboard LEDs being flashed.

> They cause the real error message:

> Cannot open root device

> and the preceding kernel messages which show a lack of detection of
> the SATA hard drive to be rapidly scrolled off screen.

> The atkbd message should at the very least be rate limited.

Here is an ugly hack that limits the above error message.

--- linux/drivers/input/keyboard/atkbd.c.orig	2006-12-05 20:34:50.000000000 +0000
+++ linux/drivers/input/keyboard/atkbd.c	2006-12-03 13:43:13.000000000 +0000
@@ -412,9 +412,16 @@
 			goto out;
 		case ATKBD_RET_ACK:
 		case ATKBD_RET_NAK:
-			printk(KERN_WARNING "atkbd.c: Spurious %s on %s. "
-			       "Some program might be trying access hardware directly.\n",
-			       data == ATKBD_RET_ACK ? "ACK" : "NAK", serio->phys);
+			{
+				static int warned = 0;
+
+				if (!warned) {
+					printk(KERN_WARNING "atkbd.c: Spurious %s on %s. "
+					       "Some program might be trying access hardware directly.\n",
+					       data == ATKBD_RET_ACK ? "ACK" : "NAK", serio->phys);
+					warned = 1;
+				}
+			}
 			goto out;
 		case ATKBD_RET_HANGEUL:
 		case ATKBD_RET_HANJA:


Signed-off-by: Alan J. Wylie <alan@...ie.me.uk>

-- 
Alan J. Wylie                                          http://www.wylie.me.uk/
"Perfection [in design] is achieved not when there is nothing left to add,
but rather when there is nothing left to take away."
  -- Antoine de Saint-Exupery
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/