linux-kernel - Re: [PATCH] VIA and SiS AGP chipsets are x86-only

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4575F929.9020708@us.ibm.com>
Date:	Tue, 05 Dec 2006 14:56:41 -0800
From:	Ian Romanick <idr@...ibm.com>
To:	Matthew Wilcox <matthew@....cx>
CC:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] VIA and SiS AGP chipsets are x86-only

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Matthew Wilcox wrote:
> There's no point in troubling the Alpha, IA-64, PowerPC and PARISC
> people with SiS and VIA options.  Andrew thinks it helps find bugs,
> but there's no evidence of that.
> 
> Signed-off-by: Matthew Wilcox <matthew@....cx>
> 
> diff --git a/drivers/char/agp/Kconfig b/drivers/char/agp/Kconfig
> index c603bf2..a9f9c48 100644
> --- a/drivers/char/agp/Kconfig
> +++ b/drivers/char/agp/Kconfig
> @@ -86,7 +86,7 @@ config AGP_NVIDIA
> 
>  config AGP_SIS
>  	tristate "SiS chipset support"
> -	depends on AGP
> +	depends on AGP && X86
>  	help
>  	  This option gives you AGP support for the GLX component of
>  	  X on Silicon Integrated Systems [SiS] chipsets.
> @@ -103,7 +103,7 @@ config AGP_SWORKS
> 
>  config AGP_VIA
>  	tristate "VIA chipset support"
> -	depends on AGP
> +	depends on AGP && X86
>  	help
>  	  This option gives you AGP support for the GLX component of
>  	  X on VIA MVP3/Apollo Pro chipsets.

I don't know about SiS, but this is certainly *not* true for Via.  There
are some PowerPC and, IIRC, Alpha motherboards that have Via chipsets.
My config-fu isn't quite what it should be, so this may be a dumb
question.  Does the "& X86" requirement exclude x86-64?
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (GNU/Linux)

iD8DBQFFdfkpX1gOwKyEAw8RAmh9AJ42g79Q9isQ0mzy87ILFn8pyW9AjACfWFdu
DvPS3GGDJyFfYfaf/8b5H4Y=
=NlmP
-----END PGP SIGNATURE-----
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/