linux-kernel - Re: [PATCH 0/3] New firewire stack

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4575FFB1.2080500@redhat.com>
Date:	Tue, 05 Dec 2006 18:24:33 -0500
From:	Kristian Høgsberg <krh@...hat.com>
To:	ray-gmail@...rabbit.org
CC:	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	linux-kernel@...r.kernel.org,
	Stefan Richter <stefanr@...6.in-berlin.de>
Subject: Re: [PATCH 0/3] New firewire stack

Ray Lee wrote:
> On 12/4/06, Kristian Høgsberg <krh@...hat.com> wrote:
>> Ok... I was planning to make big-endian versions of the structs so 
>> that the
>> endian issue would be solved.  But if the bit layout is not consistent, I
>> guess bitfields are useless for wire formats.  I didn't know that 
>> though, I
>> thought the C standard specified that the compiler should allocate 
>> bits out of
>> a word using the lower bits first.
> 
> The C standard explicitly allows it to be implementation defined.
> Having been bit by this exact problem, I can also recommend never
> using bitfields for anything other than things kept solely in local
> memory.

Yeah, I just read that paragraph in K&R... sigh.  Bitfields make the code so 
readable, though :)  Anyway, I'll rewrite it to use good old shifting and masking.

Kristian


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/