linux-kernel - Re: [PATCH] ide-cd: Handle strange interrupt on the Intel ESB2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20061205235701.74b4c07b@localhost.localdomain>
Date:	Tue, 5 Dec 2006 23:57:01 +0000
From:	Alan <alan@...rguk.ukuu.org.uk>
To:	"Bartlomiej Zolnierkiewicz" <bzolnier@...il.com>,
	linux-kernel@...r.kernel.org, akpm@...l.org,
	"Tejun Heo" <htejun@...il.com>, "Jeff Garzik" <jgarzik@...ox.com>
Subject: Re: [PATCH] ide-cd: Handle strange interrupt on the Intel ESB2

On Wed, 6 Dec 2006 00:23:03 +0100
"Bartlomiej Zolnierkiewicz" <bzolnier@...il.com> wrote:

> Looks good but aren't this trying to fix the same ICH
> issue that is fixed in libata by ap->ops->irq_clear(ap)?
> 
> [ please see Tejun's mail: http://lkml.org/lkml/2006/11/15/94 ]
> 
> If so shouldn't we apply this fix for all ICH5/6/7/8 chipsets?

Possibly. Thats one reason I made it a quirk bit. I'd certainly expect it
to be a group of related chipsets.

> Also shouldn't the fix be in IRQ handler?  Currently the fix is limited
> to ide-cd driver which seems to be the wrong place as the problem
> is supposed to happen also when using other IDE device drivers
> or/and other ATA/ATAPI devices?

The problem has only be observed with CD devices doing PIO ATAPI
commands. I am not aware of an Intel errata document that characterises
this errata so anything else so cannot guess further. Perhaps Intel can
advise ?

Alan
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/