linux-kernel - Re: [PATCH] Fix up compiler warnings in megaraid driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4574FC61.30804@garzik.org>
Date:	Mon, 04 Dec 2006 23:58:09 -0500
From:	Jeff Garzik <jeff@...zik.org>
To:	Martin Bligh <mbligh@...gle.com>
CC:	Andrew Morton <akpm@...l.org>,
	James Bottomley <James.Bottomley@...elEye.com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Fix up compiler warnings in megaraid driver

Martin Bligh wrote:
> Fix up compiler warnings in megaraid driver
> 
> Signed-off-by: Martin J. Bligh <mbligh@...gle.com>
> 
> 
> ------------------------------------------------------------------------
> 
> diff -aurpN -X /home/mbligh/.diff.exclude linux-2.6.19/drivers/scsi/megaraid.c 2.6.19-megaraid/drivers/scsi/megaraid.c
> --- linux-2.6.19/drivers/scsi/megaraid.c	2006-12-04 17:52:00.000000000 -0800
> +++ 2.6.19-megaraid/drivers/scsi/megaraid.c	2006-12-04 18:24:03.000000000 -0800
> @@ -73,10 +73,14 @@ static unsigned short int max_mbox_busy_
>  module_param(max_mbox_busy_wait, ushort, 0);
>  MODULE_PARM_DESC(max_mbox_busy_wait, "Maximum wait for mailbox in microseconds if busy (default=MBOX_BUSY_WAIT=10)");
>  
> -#define RDINDOOR(adapter)		readl((adapter)->base + 0x20)
> -#define RDOUTDOOR(adapter)		readl((adapter)->base + 0x2C)
> -#define WRINDOOR(adapter,value)		writel(value, (adapter)->base + 0x20)
> -#define WROUTDOOR(adapter,value)	writel(value, (adapter)->base + 0x2C)
> +#define RDINDOOR(adapter)		readl((volatile void __iomem *) \
> +							(adapter)->base + 0x20)
> +#define RDOUTDOOR(adapter)		readl((volatile void __iomem *) \
> +							(adapter)->base + 0x2C)
> +#define WRINDOOR(adapter,value)		writel(value, (volatile void __iomem *)\
> +							(adapter)->base + 0x20)
> +#define WROUTDOOR(adapter,value)	writel(value, (volatile void __iomem *)\
> +							(adapter)->base + 0x2C)
>  
>  /*
>   * Global variables

I posted a better fix just yesterday...

	Jeff


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/