linux-kernel - [BUG][PATCH] pcieport-driver: remove invalid warning message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <4576C092.5030202@jp.fujitsu.com>
Date:	Wed, 06 Dec 2006 22:07:30 +0900
From:	Kenji Kaneshige <kaneshige.kenji@...fujitsu.com>
To:	Greg KH <gregkh@...e.de>, tom.l.nguyen@...el.com
Cc:	linux-pci@...ey.karlin.mff.cuni.cz, linux-kernel@...r.kernel.org
Subject: [BUG][PATCH] pcieport-driver: remove invalid warning message

Hi,

I got the following warning messages on some PCI Express ports.

    pcie_portdrv_probe->Dev[1263:10cf] has invalid IRQ. Check vendor BIOS

I think this message is improper because those PCI Express ports don't
use an interrupt pin. This message should not be displayed for devices
which don't use an interrupt pin.

Thanks,
Kenji Kaneshige


The following warning message should not be displayed for devices
which don't use an interrupt pin.

    pcie_portdrv_probe->Dev[XXXX:XXXX] has invalid IRQ. Check vendor BIOS

Signed-off-by: Kenji Kaneshige <kaneshige.kenji@...fujitsu.com>

---
 drivers/pci/pcie/portdrv_pci.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)

Index: linux-2.6.19/drivers/pci/pcie/portdrv_pci.c
===================================================================
--- linux-2.6.19.orig/drivers/pci/pcie/portdrv_pci.c	2006-12-06 21:31:32.000000000 +0900
+++ linux-2.6.19/drivers/pci/pcie/portdrv_pci.c	2006-12-06 21:31:38.000000000 +0900
@@ -90,7 +90,7 @@
 		return -ENODEV;
 	
 	pci_set_master(dev);
-        if (!dev->irq) {
+        if (!dev->irq && dev->pin) {
 		printk(KERN_WARNING 
 		"%s->Dev[%04x:%04x] has invalid IRQ. Check vendor BIOS\n", 
 		__FUNCTION__, dev->device, dev->vendor);


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/