linux-kernel - Re: [PATCH] usb/hid: The HID Simple Driver Interface 0.4.1 (core)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1165418317.2756.75.camel@localhost>
Date:	Wed, 06 Dec 2006 16:18:37 +0100
From:	Marcel Holtmann <marcel@...tmann.org>
To:	Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:	Jiri Kosina <jkosina@...e.cz>, Li Yu <raise.sail@...il.com>,
	Greg Kroah Hartman <greg@...ah.com>,
	linux-usb-devel <linux-usb-devel@...ts.sourceforge.net>,
	LKML <linux-kernel@...r.kernel.org>,
	Vincent Legoll <vincentlegoll@...il.com>,
	"Zephaniah E. Hull" <warp@...allh.com>, liyu <liyu@...ss.com.cn>
Subject: Re: [PATCH] usb/hid: The HID Simple Driver Interface 0.4.1 (core)

Hi Dmitry,

> > > > I still have the same objection - the "simple'" code will have to be
> > > > compiled into the driver instead of being a separate module and
> > > > eventyally will lead to a monster-size HID module. We have this issue
> > > > with psmouse to a degree but with HID the growth potential is much
> > > > bigger IMO.
> >
> > I guess that this paragraph wasn't for me, but rather for the author of
> > the HID Simple Driver proposal, am I right?
> 
> Yes, mainly for him but also for you because we need to be able to do
> what Li Yu is trying to do and be able to tweak HID interfaces.
> 
> ...
> 
> > This split is quite painful, as there are many things happening in USB all
> > the time, so the best way seem to be just to perform big split (with
> > needed changes) at once, and then develop other things on top of it (like
> > hidraw).
> 
> Is there any reason why we can't mecanically move everything into
> drivers/hid right now? Then Greg could simply forward all patches he
> gets for HID your way and you won't have hard time merging your work
> with others...

I fully agree. Lets move and split the transports now and start the work
on top of it. My only concern is to have a clean Git tree to the full
history of HID changes stay intact and will trackable. Some quirk
decisions and other stuff is not obvious and I assume will never be when
it comes to broken HID devices.

So do you have pending HID patches. If yes, please sync them with Linus
and Jiri can setup a clean tree for the move.

Regards

Marcel


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/