linux-kernel - Re: [LinuxBIOS] [linux-usb-devel] [RFC][PATCH 0/2] x86

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <124CB3B2-C140-4B0A-96D0-21457B3DC086@kernel.crashing.org>
Date:	Wed, 6 Dec 2006 16:31:36 +0100
From:	Segher Boessenkool <segher@...nel.crashing.org>
To:	ebiederm@...ssion.com (Eric W. Biederman)
Cc:	"Lu, Yinghai" <yinghai.lu@....com>,
	Peter Stuge <stuge-linuxbios@....org>,
	linux-usb-devel@...ts.sourceforge.net,
	Stefan Reinauer <stepan@...esystems.de>,
	Greg KH <gregkh@...e.de>, linux-kernel@...r.kernel.org,
	Andi Kleen <ak@...e.de>, David Brownell <david-b@...bell.net>,
	linuxbios@...uxbios.org
Subject: Re: [LinuxBIOS] [linux-usb-devel] [RFC][PATCH 0/2] x86_64 Early usb debug port support.

>> What do you mean by
>> +	for (reps = 0; reps >= 0; reps++) {
>> ?
>
> If you will not reps is negative.  Roughly it is a loop
> that will timeout eventually if a usb debug cable is not present.

> So since I didn't know how many loop iterations made sense I allowed
> it to loop for 2^31 times or until reps goes negative.

This doesn't work however.  Signed overflow in C is undefined,
and GCC actually optimises accordingly (unless -fwrapv is used).


Segher

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/