linux-kernel - Re: -mm merge plans for 2.6.20

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 6 Dec 2006 04:46:42 +0100
From:	Horst Schirmeier <horst@...irmeier.com>
To:	Roman Zippel <zippel@...ux-m68k.org>
Cc:	Andrew Morton <akpm@...l.org>, linux-kernel@...r.kernel.org,
	Andi Kleen <ak@...e.de>, jpdenheijer@...il.com,
	Daniel Drake <dsd@...too.org>, sam@...nborg.org, miraze@....de,
	zzam@...too.org
Subject: Re: -mm merge plans for 2.6.20

Hi,

On Tue, 05 Dec 2006, Roman Zippel wrote:
> On Mon, 4 Dec 2006, Andrew Morton wrote:
> > kbuild-dont-put-temp-files-in-the-source-tree.patch
> > actually-delete-the-as-instr-ld-option-tmp-file.patch
> 
> Andi had objections about the mktemp usage and I agree with him.
> The proposed patch in bugzilla didn't have this and no further 
> justification was given for why it's needed.
> Below is a replacement patch with some improvements:
> - kbuild doesn't use $(AS), so use $(CC)
> - tmp dir needs only to be calculated once
> - reformat a bit to keep it under 80 columns and to be more readable
> 
> bye, Roman
> 
> Signed-off-by: Roman Zippel <zippel@...ux-m68k.org>

This patch looks good to me, and I'd prefer it over the (twice
corrected) one currently in -mm.

-  It's close to what Daniel Drake proposed recently [1] (main
   difference: corrects the very same problem for ld-option, which might
   otherwise bite us later) and what's already in Gentoo's patchkernel,

-  it abstains from using mktemp, hopefully making Andi happy ;),

-  resolves the current Gentoo sandbox issues without touching more
   kbuild code than necessary.

Kind regards,
 Horst

[1]Message-Id: <20061202194544.D9F057B40A0@....reactivated.net>

-- 
PGP-Key 0xD40E0E7A

Download attachment "signature.asc" of type "application/pgp-signature" (190 bytes)