linux-kernel - Re: [PATCH] WorkStruct: Fix spi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200612070650.49232.david-b@pacbell.net>
Date:	Thu, 7 Dec 2006 06:50:47 -0800
From:	David Brownell <david-b@...bell.net>
To:	linux-arm-kernel@...ts.arm.linux.org.uk
Cc:	David Howells <dhowells@...hat.com>, ben@...ff.org,
	torvalds@...l.org, akpm@...l.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] WorkStruct: Fix spi_bitbang.h

On Thursday 07 December 2006 4:44 am, David Howells wrote:
> Fix spi_bitbang.h.  It need to #include <linux/workqueue.h> before it can
> compile.
> 
> Signed-Off-By: David Howells <dhowells@...hat.com>

NAK.  Headers don't compile.  A driver including this _might_ need to
include that header; most won't.


> ---
> 
>  include/linux/spi/spi_bitbang.h |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/include/linux/spi/spi_bitbang.h b/include/linux/spi/spi_bitbang.h
> index 16ce178..33fa727 100644
> --- a/include/linux/spi/spi_bitbang.h
> +++ b/include/linux/spi/spi_bitbang.h
> @@ -1,6 +1,8 @@
>  #ifndef	__SPI_BITBANG_H
>  #define	__SPI_BITBANG_H
>  
> +#include <linux/workqueue.h>
> +
>  /*
>   * Mix this utility code with some glue code to get one of several types of
>   * simple SPI master driver.  Two do polled word-at-a-time I/O:
> 
>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/