linux-kernel - Re: [PATCH/RFC] CodingStyle updates

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4578896C.3080504@oracle.com>
Date:	Thu, 07 Dec 2006 13:36:44 -0800
From:	Randy Dunlap <randy.dunlap@...cle.com>
To:	Jan Engelhardt <jengelh@...ux01.gwdg.de>
CC:	lkml <linux-kernel@...r.kernel.org>, akpm <akpm@...l.org>,
	jesper.juhl@...il.com
Subject: Re: [PATCH/RFC] CodingStyle updates

Jan Engelhardt wrote:
> On Dec 7 2006 00:48, Randy Dunlap wrote:
>> +The preferred way to ease multiple indentation levels in a switch
>> +statement is to align the "switch" and its subordinate "case" labels in
>> +the same column instead of "double-indenting" the "case" labels.  E.g.:
>> +
>> +	switch (suffix) {
>> +	case 'G':
>> +	case 'g':
>> +		mem <<= 10;
>> +	case 'M':
>> +	case 'm':
>> +		mem << 10;
>                 ^^^^^^^^^^
> 
> Statement has no effect ;-)

Argh, thanks, fixed these.
And removed most fall-throughs to make it a better example.

>> +Use one space around (on each side of) most binary operators, such as
>> +any of these:
>> +		=  +  -  <  >  *  /  %  |  &  ^  <=  >=  ==  !=
> 
> And the ternary operator ?:

Added.

>> +but no space after unary operators:
>> +		sizeof  ++  --  &  *  +  -  ~  !  defined
> 
> And no space before these unary operators,
> ++ (postincrement) -- (postdecrement)
> 
> What keyword is "defined"? Did you have too much Perl coffee? :)
> 
>> +and no space around the '.' unary operator.
> 
> Same goes for ->

Added.

>> +Linux style for comments is the pre-C99 "/* ... */" style.
> 
> Aka C89.

Changed.

>> +Don't use C99-style "// ..." comments.
>> +
>> +The preferred style for long (multi-line) comments is:
>> +
>> +	/*
>> +	 * This is the preferred style for multi-line
>> +	 * comments in the Linux kernel source code.
>> +	 * Please use it consistently.
>> +	 */
> 
> Description: Stars to the left with two almost blank (/*, */) lines.

Added.

Thanks.  Will resend later today...

-- 
~Randy
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/