linux-kernel - Re: [PATCH] usb/hid: The HID Simple Driver Interface 0.4.1 (core)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20061207051608.GA13969@kroah.com>
Date:	Wed, 6 Dec 2006 21:16:08 -0800
From:	Greg KH <greg@...ah.com>
To:	Marcel Holtmann <marcel@...tmann.org>
Cc:	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Jiri Kosina <jkosina@...e.cz>, Li Yu <raise.sail@...il.com>,
	linux-usb-devel <linux-usb-devel@...ts.sourceforge.net>,
	LKML <linux-kernel@...r.kernel.org>,
	Vincent Legoll <vincentlegoll@...il.com>,
	"Zephaniah E. Hull" <warp@...allh.com>, liyu <liyu@...ss.com.cn>
Subject: Re: [PATCH] usb/hid: The HID Simple Driver Interface 0.4.1 (core)

On Wed, Dec 06, 2006 at 04:18:37PM +0100, Marcel Holtmann wrote:
> Hi Dmitry,
> 
> > > > > I still have the same objection - the "simple'" code will have to be
> > > > > compiled into the driver instead of being a separate module and
> > > > > eventyally will lead to a monster-size HID module. We have this issue
> > > > > with psmouse to a degree but with HID the growth potential is much
> > > > > bigger IMO.
> > >
> > > I guess that this paragraph wasn't for me, but rather for the author of
> > > the HID Simple Driver proposal, am I right?
> > 
> > Yes, mainly for him but also for you because we need to be able to do
> > what Li Yu is trying to do and be able to tweak HID interfaces.
> > 
> > ...
> > 
> > > This split is quite painful, as there are many things happening in USB all
> > > the time, so the best way seem to be just to perform big split (with
> > > needed changes) at once, and then develop other things on top of it (like
> > > hidraw).
> > 
> > Is there any reason why we can't mecanically move everything into
> > drivers/hid right now? Then Greg could simply forward all patches he
> > gets for HID your way and you won't have hard time merging your work
> > with others...
> 
> I fully agree. Lets move and split the transports now and start the work
> on top of it. My only concern is to have a clean Git tree to the full
> history of HID changes stay intact and will trackable. Some quirk
> decisions and other stuff is not obvious and I assume will never be when
> it comes to broken HID devices.
> 
> So do you have pending HID patches. If yes, please sync them with Linus
> and Jiri can setup a clean tree for the move.

I have no pending HID patches in my queue right now.  Jiri, feel free to
respin your patches against Linus's tree and send them to me now.  I can
handle the git stuff and send them to Linus.

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/