linux-kernel - Re: [PATCH 2/2] eCryptfs: Public key; packet management

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20061206215748.de51dc59.akpm@osdl.org>
Date:	Wed, 6 Dec 2006 21:57:48 -0800
From:	Andrew Morton <akpm@...l.org>
To:	Michael Halcrow <mhalcrow@...ibm.com>
Cc:	LKML <linux-kernel@...r.kernel.org>, trevor.highland@...il.com,
	tyhicks@...edu
Subject: Re: [PATCH 2/2] eCryptfs: Public key; packet management

On Wed, 6 Dec 2006 17:12:37 -0600
Michael Halcrow <mhalcrow@...ibm.com> wrote:

> Public key support code. This reads and writes packets in the header
> that contain public key encrypted file keys. It calls the messaging
> code in the previous patch to send and receive encryption and
> decryption request packets from the userspace daemon.
> 
> ...
>
> +		memset(auth_tok_list_item, 0,
> +		       sizeof(struct ecryptfs_auth_tok_list_item));
> +		kmem_cache_free(ecryptfs_auth_tok_list_item_cache,
> +				auth_tok_list_item);
>
> ...
>
> +	memset(auth_tok_list_item, 0,
> +	       sizeof(struct ecryptfs_auth_tok_list_item));
> +	kmem_cache_free(ecryptfs_auth_tok_list_item_cache,
> +			auth_tok_list_item);

That's a bit wasteful of cycles.  Or is this done to minimise the exposure
of sensitive data?  If so, a comment would be in order.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/