linux-kernel - Re: [PATCH]: typo in init/initramfs.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <OFFC8397EF.1D0C38CD-ONC125723E.002EA3BB-C125723E.002EE367@philips.com>
Date:	Fri, 8 Dec 2006 09:32:03 +0100
From:	Jean-Paul Saman <jean-paul.saman@....com>
To:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH]: typo in init/initramfs.c

linux-kernel-owner@...r.kernel.org wrote on 06-12-2006 19:17:27:

> Jean-Paul Saman wrote:
> >
> > In populate_rootfs() the printk on line 554. It says "Unpacking
> > initramfs..", which is confusing because if that line is reached the 
code
> > has already decided that the image is an initrd image.
> 
> Are you sure?

Yes.

> 
> > The printk is thus
> > wrong in stating that it is unpacking an "initramfs". It should says
> > "initrd" instead. The attached patch corrects this typo.
> >
> > Signed-off-by: Jean-Paul Saman <jean-paul.saman@....com>
> >
> > diff --git a/init/initramfs.c b/init/initramfs.c
> > index d28c109..f6020db 100644
> > --- a/init/initramfs.c
> > +++ b/init/initramfs.c
> > @@ -551,7 +551,7 @@ #ifdef CONFIG_BLK_DEV_RAM
> 
> This is where initramfs is discerned from initrd, as both are available.
> 
> >                         free_initrd();
> >                 }
> >  #else
> 
> Otherwise it's initramfs only.

No otherwise it falls under CONFIG_BLK_DEV_INITRD and it that suggests it 
must be a initrd, not a initramfs as the original printk() suggests.

> 
> > -               printk(KERN_INFO "Unpacking initramfs...");
> > +              printk(KERN_INFO "Unpacking initrd...");
> >                 err = unpack_to_rootfs((char *)initrd_start,
> >                         initrd_end - initrd_start, 0);
> >                 if (err)
> >
> > -

Kind greetings,

Jean-Paul Saman

NXP Semiconductors CTO/RTG DesignIP
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/