linux-kernel - Re: [PATCH] hci endianness annotations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1165579081.5529.31.camel@aeonflux.holtmann.net>
Date:	Fri, 08 Dec 2006 12:58:01 +0100
From:	Marcel Holtmann <marcel@...tmann.org>
To:	Al Viro <viro@....linux.org.uk>
Cc:	Linus Torvalds <torvalds@...l.org>, davem@...emloft.net,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] hci endianness annotations


> Signed-off-by: Al Viro <viro@...iv.linux.org.uk>

Signed-off-by: Marcel Holtmann <marcel@...tmann.org>

> ---
>  include/net/bluetooth/hci.h |    4 ++--
>  net/bluetooth/hci_sock.c    |    4 ++--
>  2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/include/net/bluetooth/hci.h b/include/net/bluetooth/hci.h
> index 10a3eec..41456c1 100644
> --- a/include/net/bluetooth/hci.h
> +++ b/include/net/bluetooth/hci.h
> @@ -739,13 +739,13 @@ #define HCI_DEV_NONE	0xffff
>  struct hci_filter {
>  	unsigned long type_mask;
>  	unsigned long event_mask[2];
> -	__u16   opcode;
> +	__le16   opcode;
>  };
>  
>  struct hci_ufilter {
>  	__u32   type_mask;
>  	__u32   event_mask[2];
> -	__u16   opcode;
> +	__le16   opcode;
>  };
>  
>  #define HCI_FLT_TYPE_BITS	31
> diff --git a/net/bluetooth/hci_sock.c b/net/bluetooth/hci_sock.c
> index 711a085..dbf98c4 100644
> --- a/net/bluetooth/hci_sock.c
> +++ b/net/bluetooth/hci_sock.c
> @@ -123,10 +123,10 @@ void hci_send_to_sock(struct hci_dev *hd
>  			if (flt->opcode &&
>  			    ((evt == HCI_EV_CMD_COMPLETE &&
>  			      flt->opcode !=
> -			      get_unaligned((__u16 *)(skb->data + 3))) ||
> +			      get_unaligned((__le16 *)(skb->data + 3))) ||
>  			     (evt == HCI_EV_CMD_STATUS &&
>  			      flt->opcode !=
> -			      get_unaligned((__u16 *)(skb->data + 4)))))
> +			      get_unaligned((__le16 *)(skb->data + 4)))))
>  				continue;
>  		}
>  

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/