linux-kernel - Re: [PATCH] cpuset - rework cpuset_zone

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6599ad830612080851q55fe8c95m9f00a2a9a3779dc4@mail.gmail.com>
Date:	Fri, 8 Dec 2006 08:51:01 -0800
From:	"Paul Menage" <menage@...gle.com>
To:	"Paul Jackson" <pj@....com>
Cc:	"Andrew Morton" <akpm@...l.org>, linux-kernel@...r.kernel.org,
	"Nick Piggin" <nickpiggin@...oo.com.au>, "Andi Kleen" <ak@...e.de>,
	"Christoph Lameter" <clameter@....com>
Subject: Re: [PATCH] cpuset - rework cpuset_zone_allowed api

On 12/8/06, Paul Jackson <pj@....com> wrote:
>
> -int __cpuset_zone_allowed(struct zone *z, gfp_t gfp_mask)
> +int __cpuset_zone_allowed_softwall(struct zone *z, gfp_t gfp_mask)
>  {
>         int node;                       /* node that zone z is on */
>         const struct cpuset *cs;        /* current cpuset ancestors */
> @@ -2335,6 +2351,40 @@ int __cpuset_zone_allowed(struct zone *z
>         return allowed;
>  }

While you're changing this, is there a good reason not to check
is_mem_exclusive() *before* taking callback_mutex and calling
nearest_exclusive_ancestor()?

something like:

rcu_read_lock();
exc = is_mem_exclusive(rcu_dereference(current->cs));
rcu_read_unlock();
if (exc)
  return 1;

... take callback_mutex, etc ...

Paul
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/