linux-kernel - Re: [PATCH 26/35] Unionfs: Privileged operations workqueue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 8 Dec 2006 19:03:00 +0100 (MET)
From:	Jan Engelhardt <jengelh@...ux01.gwdg.de>
To:	Josef Sipek <jsipek@....cs.sunysb.edu>
cc:	"Josef 'Jeff' Sipek" <jsipek@...sunysb.edu>,
	linux-kernel@...r.kernel.org, torvalds@...l.org, akpm@...l.org,
	hch@...radead.org, viro@....linux.org.uk,
	linux-fsdevel@...r.kernel.org, mhalcrow@...ibm.com
Subject: Re: [PATCH 26/35] Unionfs: Privileged operations workqueue


On Dec 8 2006 12:43, Josef Sipek wrote:
>> On Dec 8 2006 11:00, Josef Sipek wrote:
>> 
>> +void __unionfs_mkdir(void *data)
>> +{
>> +	struct sioq_args *args = data;
>> +	struct mkdir_args *m = &args->mkdir;
>> +
>> +	args->err = vfs_mkdir(m->parent, m->dentry, m->mode);
>> +	complete(&args->comp);
>> +}
>> 
>> >> The members of m (i.e. m->*) are not modified as for as __unionfs_mknod goes.
>> >> vfs_mknod may only modify the members of m->parent (i.e. m->parent->*)
>> > 
>> >Yes they are. The return value is passed through a member of m.
>> 
>> Where - where do you see that m->parent, m->dentry or m->mode are modified?
>> (The original submission is above.)
>
>args->err is modified. If args is declared const, gcc complains.

I never said making "args" const, but
rather [-> http://lkml.org/lkml/2006/12/5/210 ] I said:

  "Care to make that: const struct mknod_args *m = &args->mknod;?"


	-`J'
-- 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/