linux-kernel - Re: [PATCH] efi is_memory_available ia64 hack build fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 8 Dec 2006 11:12:03 -0800
From:	Randy Dunlap <randy.dunlap@...cle.com>
To:	Andrew Morton <akpm@...l.org>
Cc:	Paul Jackson <pj@....com>, linux-kernel@...r.kernel.org,
	davej@...emonkey.org.uk,
	"Myaskouvskey, Artiom" <artiom.myaskouvskey@...el.com>,
	shai.satt@...el.com, Andi Kleen <ak@...e.de>, hpa@...or.com
Subject: Re: [PATCH] efi is_memory_available ia64 hack build fix

On Fri, 8 Dec 2006 02:53:12 -0800 Andrew Morton wrote:

> On Fri, 08 Dec 2006 02:33:36 -0800
> Paul Jackson <pj@....com> wrote:
> 
> > The addition of an is_available_memory() routine to some arch i386
> > code, along with an extern for it in efi.h, caused the ia64 build
> > to fail, which has the apparently identical routine, marked 'static'.
> > 
> > The ia64 build fails with:
> > 
> > arch/ia64/kernel/efi.c:229: error: static declaration of 'is_available_memory' follows non-static declaration
> > include/linux/efi.h:305: error: previous declaration of 'is_available_memory' was here              
> 
> That already got named to is_memory_available()
> 
> (Which I suspect is the wrong fix, because the function serves the same
> purpose on ia64 as it does on x86[_64], but nobody listens to me)

Paul's patch looks better to me than renaming one of them.
And the predicate name on ia64 now seems confusing, at least to me.

And EFI for x86_64 is being worked on, so it will either
use arch/i386/kernel/efi.c or duplicate lots of it.

Summary:  There needs to be a place to share this and possibly other
common functions.

---
~Randy
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/