linux-kernel - Re: [PATCH] fs/jfs: fix error due to PF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20061208112330.7e8d4e88.randy.dunlap@oracle.com>
Date:	Fri, 8 Dec 2006 11:23:30 -0800
From:	Randy Dunlap <randy.dunlap@...cle.com>
To:	Richard Knutsson <ricknu-0@...dent.ltu.se>
Cc:	Linus Torvalds <torvalds@...l.org>, linux-kernel@...r.kernel.org,
	shaggy@...tin.ibm.com
Subject: Re: [PATCH] fs/jfs: fix error due to PF_* undeclared

On Fri, 08 Dec 2006 19:56:20 +0100 Richard Knutsson wrote:

>   CC [M]  fs/jfs/jfs_txnmgr.o
> In file included from fs/jfs/jfs_txnmgr.c:49:
> include/linux/freezer.h: In function ‘frozen’:
> include/linux/freezer.h:9: error: dereferencing pointer to incomplete type
> include/linux/freezer.h:9: error: ‘PF_FROZEN’ undeclared (first use in this function)
> <snip>
> fs/jfs/jfs_txnmgr.c: In function ‘freezing’:
> include/linux/freezer.h:18: warning: control reaches end of non-void function
> make[2]: *** [fs/jfs/jfs_txnmgr.o] Error 1
> make[1]: *** [fs/jfs] Error 2
> make: *** [fs] Error 2
> 
> Signed-off-by: Richard Knutsson <ricknu-0@...dent.ltu.se>
> 
> ---
> 
> Guess this is the desired fix, since including linux/sched.h in linux/freezer.h
> make little sense.

Why do you say that?  freezer.h is what uses those #defined values,
and freezer.h is what uses struct task_struct fields as well,
so it needs sched.h.


> 
> diff --git a/fs/jfs/jfs_txnmgr.c b/fs/jfs/jfs_txnmgr.c
> index d558e51..2aee0a8 100644
> --- a/fs/jfs/jfs_txnmgr.c
> +++ b/fs/jfs/jfs_txnmgr.c
> @@ -46,6 +46,7 @@ #include <linux/fs.h>
>  #include <linux/vmalloc.h>
>  #include <linux/smp_lock.h>
>  #include <linux/completion.h>
> +#include <linux/sched.h>
>  #include <linux/freezer.h>
>  #include <linux/module.h>
>  #include <linux/moduleparam.h>
> 
> -

---
~Randy
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/