linux-kernel - Re: [GIT PATCH] HID patches for 2.6.19

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 8 Dec 2006 22:34:16 +0100 (CET)
From:	Jiri Kosina <jkosina@...e.cz>
To:	Marcel Holtmann <marcel@...tmann.org>,
	Linus Torvalds <torvalds@...l.org>
Cc:	Greg KH <gregkh@...e.de>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	linux-kernel@...r.kernel.org, linux-usb-devel@...ts.sourceforge.net
Subject: Re: [GIT PATCH] HID patches for 2.6.19

On Fri, 8 Dec 2006, Marcel Holtmann wrote:

> since we don't have any user-space or out of kernel HID transport 
> drivers at the moment it would make sense to simply select HID if 
> someone selects USB_HID or the upcoming Bluetooth transport.

OK, I agree. Something like this? (applies on top of previous patches, 
or I could collapse all the Kconfig changes into one patch if desired)

Thanks.

[PATCH] Generic HID layer - build: USB_HID should select HID, not depend on it

Let CONFIG_USB_HID imply CONFIG_HID. Making it only dependent might confuse
users to choose CONFIG_HID, but no particular HID transport drivers.

Signed-off-by: Jiri Kosina <jkosina@...e.cz>

---
commit a94cfd7aa1df1e89b058d6eaf347ce94cd10ba71
tree b11cb076d4528603c8c11220691801231d6236c8
parent 3ecbf35f6a6b45ecbf03002da8dd6fe030196ed3
author Jiri Kosina <jkosina@...e.cz> Fri, 08 Dec 2006 22:29:13 +0100
committer Jiri Kosina <jkosina@...e.cz> Fri, 08 Dec 2006 22:29:13 +0100

 drivers/usb/input/Kconfig |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/drivers/usb/input/Kconfig b/drivers/usb/input/Kconfig
index 8a62d47..e308f6d 100644
--- a/drivers/usb/input/Kconfig
+++ b/drivers/usb/input/Kconfig
@@ -7,7 +7,8 @@ comment "USB Input Devices"
 config USB_HID
 	tristate "USB Human Interface Device (full HID) support"
 	default y
-	depends on USB && HID
+	depends on USB
+	select HID
 	---help---
 	  Say Y here if you want full HID support to connect USB keyboards,
 	  mice, joysticks, graphic tablets, or any other HID based devices

-- 
Jiri Kosina
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/