linux-kernel - Re: [PATCH 2/6] e1000: use pcix_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <adalkli6p0e.fsf@cisco.com>
Date:	Fri, 08 Dec 2006 13:45:05 -0800
From:	Roland Dreier <rdreier@...co.com>
To:	Stephen Hemminger <shemminger@...l.org>
Cc:	Greg Kroah-Hartman <gregkh@...e.de>,
	linux-pci@...ey.karlin.mff.cuni.cz, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/6] e1000: use pcix_set_mmrbc

 > -        if (hw->bus_type == e1000_bus_type_pcix) {
 > -            e1000_read_pci_cfg(hw, PCIX_COMMAND_REGISTER, &pcix_cmd_word);
 > -            e1000_read_pci_cfg(hw, PCIX_STATUS_REGISTER_HI,
 > -                &pcix_stat_hi_word);
 > -            cmd_mmrbc = (pcix_cmd_word & PCIX_COMMAND_MMRBC_MASK) >>
 > -                PCIX_COMMAND_MMRBC_SHIFT;
 > -            stat_mmrbc = (pcix_stat_hi_word & PCIX_STATUS_HI_MMRBC_MASK) >>
 > -                PCIX_STATUS_HI_MMRBC_SHIFT;
 > -            if (stat_mmrbc == PCIX_STATUS_HI_MMRBC_4K)
 > -                stat_mmrbc = PCIX_STATUS_HI_MMRBC_2K;
 > -            if (cmd_mmrbc > stat_mmrbc) {
 > -                pcix_cmd_word &= ~PCIX_COMMAND_MMRBC_MASK;
 > -                pcix_cmd_word |= stat_mmrbc << PCIX_COMMAND_MMRBC_SHIFT;
 > -                e1000_write_pci_cfg(hw, PCIX_COMMAND_REGISTER,
 > -                    &pcix_cmd_word);
 > -            }
 > -        }
 > +        if (hw->bus_type == e1000_bus_type_pcix)
 > +		e1000_pcix_set_mmrbc(hw, 2048);

This changes the behavior of the driver.  The existing driver only
sets MMRBC if it's bigger than min(2048, value in the status register).
You're setting MMRBC to 2048 even if it starts out at a smaller value.

 - R.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/