linux-kernel - Re: [PATCH 2.6.19] drivers/media/video/cpia2/cpia2_usb.c: Free previously allocated memory (in array elements) if kmalloc() returns NULL.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200612080109.27018.m.kozlowski@tuxland.pl>
Date:	Fri, 8 Dec 2006 01:09:26 +0100
From:	Mariusz Kozlowski <m.kozlowski@...land.pl>
To:	David Rientjes <rientjes@...washington.edu>
Cc:	Amit Choudhary <amit2030@...il.com>,
	Linux Kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2.6.19] drivers/media/video/cpia2/cpia2_usb.c: Free previously allocated memory (in array elements) if kmalloc() returns NULL.

Hello, 

> > Just for future. Shorter and more readable version of your for(...) thing:
> > 
> > 	while (i--) {
> > 		...
> > 	}
> > 
> 
> No, that is not equivalent.
> 
> You want
> 	while (i-- >= 0) {
> 		...
> 	}
> 

Not really. That will stop at -1 not 0.

-- 
Regards,

	Mariusz Kozlowski
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/