linux-kernel - Re: sysfs file creation result nightmare (WAS radeonfb: Fix sysfs_create_bin

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 10 Dec 2006 07:55:47 +1100
From:	Benjamin Herrenschmidt <benh@...nel.crashing.org>
To:	Andrew Morton <akpm@...l.org>
Cc:	Jean Delvare <khali@...ux-fr.org>,
	Paul Mackerras <paulus@...ba.org>,
	Linux Kernel list <linux-kernel@...r.kernel.org>
Subject: Re: sysfs file creation result nightmare (WAS radeonfb: Fix
	sysfs_create_bin_file warnings)

> > Why would I prevent the framebuffer from initializing (and thus a
> > console to be displayed at all on many machines) just because for some
> > reason, I couldn't create a pair of EDID files in sysfs that are not
> > even very useful anymore ?
> 
> Because there's a bug in your kernel.  We don't hide and work around bugs.

But not initializing the fbdev will be much more effective at hiding the
bug than just displaying a warning, which could just be done inside
sysfs_create_file.

Besides, in most cases, there is no bug. That is, there is no bug that
will cause the file creation to fail and it will not fail.

> Just fix the bugs, for heck's sake.

Considering that in 99% of the case, the creation cannot fail unless
some cosmic ray hit your machine or you are running oom... that is,
plenty of cases where there is _no_ bug now gets a useless code bloat
for checking a result code where there is nothing sane you can do about
it anyway.

Ben.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/