linux-kernel - Re: [PATCH] 2.6 driver for Silan SC92031 (second try)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20061208220114.b531bee0.akpm@osdl.org>
Date:	Fri, 8 Dec 2006 22:01:14 -0800
From:	Andrew Morton <akpm@...l.org>
To:	Cesar Eduardo Barros <cesarb@...arb.net>
Cc:	netdev@...r.kernel.org, Jeff Garzik <jgarzik@...ox.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] 2.6 driver for Silan SC92031 (second try)

On Fri, 08 Dec 2006 18:17:06 -0200
Cesar Eduardo Barros <cesarb@...arb.net> wrote:

> From: Cesar Eduardo Barros <cesarb@...arb.net>
> 
> This is a driver for the Silan SC92031/Rsltek 8139D NIC chip.
> 
> ...

> +config SC92031
> +	depends on NET_PCI && PCI && EXPERIMENTAL
> +	select CRC32
>
> ...
>
> +	} while(unlikely(cmpxchg(&priv->intr_status,

You'll have the arm maintainer after you with a pointy stick.

cmpxchg is only available on certain architectures.  It would be acceptable
to make this driver depend on X86 (or something).  Better to rewrite this
code so it doesn't use cmpxchg.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/