linux-kernel - Re: [PATCH] x86 smp: export smp_num

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20061209004939.85d72e2c.akpm@osdl.org>
Date:	Sat, 9 Dec 2006 00:49:39 -0800
From:	Andrew Morton <akpm@...l.org>
To:	Randy Dunlap <randy.dunlap@...cle.com>
Cc:	lkml <linux-kernel@...r.kernel.org>, phil.el@...adoo.fr, ak@...e.de
Subject: Re: [PATCH] x86 smp: export smp_num_siblings for oprofile

On Sat, 9 Dec 2006 00:34:24 -0800
Randy Dunlap <randy.dunlap@...cle.com> wrote:

> From: Randy Dunlap <randy.dunlap@...cle.com>
> 
> oprofile uses smp_num_siblings without testing for CONFIG_X86_HT.
> I looked at modifying oprofile, but this way is cleaner & simpler
> and I didn't see a good reason not to just export it when CONFIG_SMP.
> 
> WARNING: "smp_num_siblings" [arch/i386/oprofile/oprofile.ko] undefined!
> 
> Signed-off-by: Randy Dunlap <randy.dunlap@...cle.com>
> ---
>  arch/i386/kernel/smpboot.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- linux-2.6.19-git13.orig/arch/i386/kernel/smpboot.c
> +++ linux-2.6.19-git13/arch/i386/kernel/smpboot.c
> @@ -69,7 +69,7 @@ static int __devinitdata smp_b_stepping;
>  
>  /* Number of siblings per CPU package */
>  int smp_num_siblings = 1;
> -#ifdef CONFIG_X86_HT
> +#ifdef CONFIG_SMP
>  EXPORT_SYMBOL(smp_num_siblings);
>  #endif

smpboot.c isn't compiled if CONFIG_SMP=n, so I'll just remove the ifdef,
thanks.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/