linux-kernel - Re: optimalisation for strlcpy (lib/string.c)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20061210215504.GD47959@gaz.sfgoth.com>
Date:	Sun, 10 Dec 2006 13:55:04 -0800
From:	Mitchell Blank Jr <mitch@...oth.com>
To:	Folkert van Heusden <folkert@...heusden.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: optimalisation for strlcpy (lib/string.c)

Folkert van Heusden wrote:
> Like the other patch (by that other person), I think it is faster to not
> do a strlen first.

Debatable.  You've replaced a call to the highly-optimized memcpy function
with a byte-by-byte copy.  It's probably a wash performance wise (have you
benchmarked?) and is certainly less clear.

-Mitch
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/