linux-kernel - Re: [PATCH 2/3] Import fw-ohci driver.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <457C8075.4030000@redhat.com>
Date:	Sun, 10 Dec 2006 16:47:33 -0500
From:	Kristian Høgsberg <krh@...hat.com>
To:	Stefan Richter <stefanr@...6.in-berlin.de>
CC:	Jeff Garzik <jeff@...zik.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] Import fw-ohci driver.

Stefan Richter wrote:
> Kristian Høgsberg wrote:
>> Yup, I've done away with the bitfields and switched to a mix of __le16
>> and __le32 struct fields.
> 
> I suppose the struct should get __attribute__((packed)) then.

I guess it wouldn't harm, but is it really necessary?  Would gcc ever insert 
padding here, all the 32 bit fields a 32 bit aligned, and so are the 16 bit 
fields.

> But is the order of two adjacent __le16 fields (i.e. two halves of a
> quadlet) independent of host byte order?

Yeah, it works for both be and le cpus.  The layout is le specific, which is 
how the host controller wants it.

cheers,
Kristian

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/