linux-kernel - Re: [BUG] commit 3c517a61, slab: better fallback allocation behavior

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20061210141435.afac089d.akpm@osdl.org>
Date:	Sun, 10 Dec 2006 14:14:35 -0800
From:	Andrew Morton <akpm@...l.org>
To:	Paul Jackson <pj@....com>
Cc:	Jay Cliburn <jacliburn@...lsouth.net>,
	linux-kernel@...r.kernel.org, clameter@....com
Subject: Re: [BUG] commit 3c517a61, slab: better fallback allocation
 behavior

On Sun, 10 Dec 2006 12:49:07 -0800
Paul Jackson <pj@....com> wrote:

> Good report - thanks.
> 
> Christoph - fallback_alloc() can be called with interrupts off.
> 
> I fixed the cpuset_zone_allowed() call from fallback_alloc() to avoid
> sleeping.  Notice the __GFP_HARDWALL added in Linus's version, or the
> new function cpuset_zone_allowed_hardwall() in Andrew's version, all
> done in the last week.
> 
> But apparently kmem_getpages() can also sleep, as it calls __alloc_pages().
> 

This is lame.  Please, always always test all new submissions with all the
nice kernel debugging options enabled.

They are summarised in Documentation/SubmitChecklist, along with a number
of other useful bug-prevention suggestions.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/