linux-kernel - Re: RFC: PCI quirks update for 2.6.16

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 10 Dec 2006 17:00:53 +0100
From:	Adrian Bunk <bunk@...sta.de>
To:	Sergio Monteiro Basto <sergio@...giomb.no-ip.org>
Cc:	Daniel Drake <dsd@...too.org>, Daniel Ritz <daniel.ritz@....ch>,
	Jean Delvare <khali@...ux-fr.org>,
	Bjorn Helgaas <bjorn.helgaas@...com>,
	Linus Torvalds <torvalds@...l.org>,
	Brice Goglin <brice@...i.com>,
	"John W. Linville" <linville@...driver.com>,
	Bauke Jan Douma <bjdouma@...all.nl>,
	Tomasz Koprowski <tomek@...rowski.org>, gregkh@...e.de,
	linux-kernel@...r.kernel.org, linux-pci@...ey.karlin.mff.cuni.cz
Subject: Re: RFC: PCI quirks update for 2.6.16

On Sun, Dec 10, 2006 at 04:09:39AM +0000, Sergio Monteiro Basto wrote:
> On Thu, 2006-12-07 at 09:38 -0500, Daniel Drake wrote:
> > Adrian Bunk wrote:
> > > Daniel Drake (1):
> > >       PCI: VIA IRQ quirk behaviour change
> > 
> > Please drop this one, Alan isn't 100% on it and is working on getting a 
> > better fix into mainline
> > 
> > Daniel
> 
> Sorry Daniel, I don't agree with you, this patch is a improvement of the
> original patch and in my opinion should go in.
> As Alan explain to us, is not the prefect one, but still be an
> improvement.

Below is the patch for going back to the 2.6.16.16 status quo that is in 
2.6.16.36-rc1.

Does this cause any serious regression for anyone?

> Thanks,
> Sérgio M. B. 

cu
Adrian


commit dcb1715778026c4aec20d186dc794245d9a1f5de
Author: Adrian Bunk <bunk@...sta.de>
Date:   Fri Dec 8 17:00:35 2006 +0100

    revert the quirk_via_irq changes
    
    This patch reverts the quirk_via_irq changes in 2.6.16.17 that
    caused regressions for several people.
    
    Signed-off-by: Adrian Bunk <bunk@...sta.de>

diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
index a1cdf06..2a66e39 100644
--- a/drivers/pci/quirks.c
+++ b/drivers/pci/quirks.c
@@ -656,13 +656,7 @@ static void quirk_via_irq(struct pci_dev *dev)
 		pci_write_config_byte(dev, PCI_INTERRUPT_LINE, new_irq);
 	}
 }
-DECLARE_PCI_FIXUP_ENABLE(PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_82C586_0, quirk_via_irq);
-DECLARE_PCI_FIXUP_ENABLE(PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_82C586_1, quirk_via_irq);
-DECLARE_PCI_FIXUP_ENABLE(PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_82C586_2, quirk_via_irq);
-DECLARE_PCI_FIXUP_ENABLE(PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_82C586_3, quirk_via_irq);
-DECLARE_PCI_FIXUP_ENABLE(PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_82C686, quirk_via_irq);
-DECLARE_PCI_FIXUP_ENABLE(PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_82C686_4, quirk_via_irq);
-DECLARE_PCI_FIXUP_ENABLE(PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_82C686_5, quirk_via_irq);
+DECLARE_PCI_FIXUP_ENABLE(PCI_VENDOR_ID_VIA, PCI_ANY_ID, quirk_via_irq);
 
 /*
  * VIA VT82C598 has its device ID settable and many BIOSes
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/