linux-kernel - Re: Mark bitrevX() functions as const

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <457D5E01.7010307@garzik.org>
Date:	Mon, 11 Dec 2006 08:32:49 -0500
From:	Jeff Garzik <jeff@...zik.org>
To:	David Howells <dhowells@...hat.com>
CC:	Akinobu Mita <akinobu.mita@...il.com>, torvalds@...l.org,
	akpm@...l.org, linux-kernel@...r.kernel.org,
	Al Viro <viro@...iv.linux.org.uk>
Subject: Re: Mark bitrevX() functions as const

David Howells wrote:
> Jeff Garzik <jeff@...zik.org> wrote:
>> * naked __attribute__ is ugly.  define something short and memorable in
>> include/linux/compiler.h.
> 
> I'm not sure that's a good idea.  You have to be careful not to cause confusion
> with ordinary "const".

It's all in the naming.  You could call it 'purefunc' or somesuch.

__attribute__ is very very ugly, an hinders a quick scan of the function 
prototype, particularly if it has a boatload of other attributes.


>> * another annotation to consider is C99 keyword 'restrict'.
> 
> Indeed, though I presume you don't mean in this particular case...

Correct.

	Jeff



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/