linux-kernel - Re: [PATCH] cfq: wrong sync writes detection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20061211160817.GS4576@kernel.dk>
Date:	Mon, 11 Dec 2006 17:08:17 +0100
From:	Jens Axboe <jens.axboe@...cle.com>
To:	Vasily Tarasov <vtaras@...nvz.org>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Kirill Korotaev <dev@...nvz.org>,
	OpenVZ Developers List <devel@...nvz.org>
Subject: Re: [PATCH] cfq: wrong sync writes detection

On Mon, Dec 11 2006, Vasily Tarasov wrote:
> CFQ I/O scheduler does the following actions to
> find out whether the request is sync:
> 
> rw = rq_data_dir(rq); => possible values for rw are 0 or 1
> 
> static inline pid_t cfq_queue_pid(struct task_struct *task, int rw)
> {
>         if (rw == READ || rw == WRITE_SYNC) => second condition is always false
>                 return task->pid;
> 
>         return CFQ_KEY_ASYNC;
> }
> 
> The following patch fixes the bug by adding sync parameter,
> wich is obtained through bio_sync macros.

Good catch! Applied.

-- 
Jens Axboe

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/