linux-kernel - Re: [PATCH -mm] sata_nv: add suspend/resume support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 11 Dec 2006 11:27:28 -0500
From:	Jeff Garzik <jeff@...zik.org>
To:	Robert Hancock <hancockr@...w.ca>
CC:	linux-kernel <linux-kernel@...r.kernel.org>,
	linux-ide@...r.kernel.org, Andrew Morton <akpm@...l.org>
Subject: Re: [PATCH -mm] sata_nv: add suspend/resume support

Robert Hancock wrote:
> +static void nv_remove_one (struct pci_dev *pdev)
> +{
> +	struct ata_host *host = dev_get_drvdata(&pdev->dev);
> +	struct nv_host_priv *hpriv = host->private_data;
> +	
> +	kfree(hpriv);
> +	ata_pci_remove_one(pdev);
> +}	


It is unwise to free the struct before the ports are even detached.

Otherwise, seems ok, but I would like to see some more positive user 
reports (both ADMA and not) before pushing upstream.

	Jeff


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/