linux-kernel - Re: [PATCH] input/usb: Supporting more keys from the HUT Consumer Page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1165865441.20733.12.camel@localhost>
Date:	Mon, 11 Dec 2006 20:30:41 +0100
From:	Marcel Holtmann <marcel@...tmann.org>
To:	Florian Festi <ffesti@...hat.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] input/usb: Supporting more keys from the HUT Consumer
	Page

Hi Florian,

> On USB keyboards lots of hot/internet keys are not working. This patch 
> adds support for a number of keys from the USB HID Usage Table 
> (http://www.usb.org/developers/devclass_docs/Hut1_12.pdf).
> 
> It also adds several new key codes. Most of them are used on real world 
> keyboards I know. I added some others (KEY_+ EDITOR, GRAPHICSEDITOR, 
> DATABASE, NEWS, VOICEMAIL, VIDEOPHONE) to avoid "holes".
> 
> I would be interested in comments to the "zoom" key. For me it looks 
> like KEY_ZOOM is on a remote control for a DVD player or something 
> similar. So it toggles between a few zoom levels. The Zoom 100% key 
> found on keyboards (some Logitech internet keyboards for example) resets 
> the Zoom to 100%. May be we need another keycode for them. Additionally
> does the USB HUT define the Zoom entry as "linear control" but the 
> logitech uses it as Zoom 100% key.

we just split the HID parser from the actual USB transport driver and it
seems your patch is against an old tree. Please update your patch.

Regards

Marcel


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/