linux-kernel - Re: [PATCH -mm] sata_nv: fix kfree ordering in remove

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 12 Dec 2006 06:35:23 -0500
From:	Jeff Garzik <jeff@...zik.org>
To:	Robert Hancock <hancockr@...w.ca>
CC:	linux-kernel <linux-kernel@...r.kernel.org>,
	linux-ide@...r.kernel.org, Andrew Morton <akpm@...l.org>
Subject: Re: [PATCH -mm] sata_nv: fix kfree ordering in remove

Robert Hancock wrote:
> Jeff Garzik wrote:
>> It is unwise to free the struct before the ports are even detached.
> 
> Right, theoretically something bad could happen here (though not 
> likely). Here's a fix. Sorry for attaching with something so trivial, 
> but Thunderbird isn't very cooperative..

You'll need to resend the entire patch, I dropped it due to that 
comment.  In general, before a patch is applied, the patch will go 
through several revisions.  I don't apply things piecemeal, only the 
last (hopefully perfect:)) revision.

Also, as your email already guessed, attachments are to be avoided :/

	Jeff



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/