linux-kernel - Re: [PATCH 2.6.19] e1000: replace kmalloc with kzalloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 12 Dec 2006 10:32:46 -0800
From:	Auke Kok <auke-jan.h.kok@...el.com>
To:	Pekka Enberg <penberg@...helsinki.fi>
CC:	Yan Burman <burman.yan@...il.com>, linux-kernel@...r.kernel.org,
	trivial@...nel.org
Subject: Re: [PATCH 2.6.19] e1000: replace kmalloc with kzalloc

Pekka Enberg wrote:
> On 12/12/06, Yan Burman <burman.yan@...il.com> wrote:
>>         size = txdr->count * sizeof(struct e1000_buffer);
>> -       if (!(txdr->buffer_info = kmalloc(size, GFP_KERNEL))) {
>> +       if (!(txdr->buffer_info = kzalloc(size, GFP_KERNEL))) {
>>                 ret_val = 1;
>>                 goto err_nomem;
>>         }
>> -       memset(txdr->buffer_info, 0, size);
> 
> No one seems to be using size elsewhere so why not convert to
> kcalloc() and get rid of it? (Seems to apply to other places as well.)

I'll put it on my todo list.

Auke
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/